Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MinGW/GCC 10 report with -Wuseless-cast
What does this change do?
Fix three Warnings of casting
T
to `T´.Is it related to an exisiting bug report or feature request?
No
Pre-merge checklist
origin/master
(if necessary)(*): MinGW/GCC 10: I needed two changes:
add_project_arguments(has_exceptions ? '-D_HAS_EXCEPTIONS=1' : '-D_HAS_EXCEPTIONS=0', language : 'cpp')
otherwise it gets defined twice and results in an error:Deactivate the
THIS_IS_AN_EVIL_MACRO
because it modifiedstd::min
,std::numeric_limits::min
, and themax
counterparts. I don't know if this test is designed to work with MinGW, or just MSVC.Locales seem to work differently (or not at all?) with MinGW.
Anything else?