Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use most specific matching prefix #91

Closed
PaulWalkerUK opened this issue Jan 30, 2022 · 4 comments
Closed

Use most specific matching prefix #91

PaulWalkerUK opened this issue Jan 30, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@PaulWalkerUK
Copy link

Currently, LON_C_CTR and LON_N_CTR are online. However, these controllers are both only showing up under the full EGTT sector, rather than the more specific EGTT_N and EGTT_C.

I think this is driven by this part of VATspy.dat:

EGTT|London|LON|EGTT
EGTT-C|London ACC (Central) - London|LON_C|EGTT-C
EGTT-C|London ACC (Central) - London|LON_E|EGTT-C
EGTT-C|London ACC (Central) - London|LTC_N|EGTT-C
EGTT-C|London ACC (Central) - London|LTC_NW|EGTT-C
EGTT-N|London ACC (North) - London|LON_N|EGTT-N

If I edit this file to comment out the line EGTT|London|LON|EGTT it works as expected.

I'm not sure what logic it's currently using to match the callsign to the sector, but I wonder if it could search for the longest matching string and match against LON_C and LON_N instead of the more general LON?

@PaulWalkerUK PaulWalkerUK added the enhancement New feature or request label Jan 30, 2022
@marvk
Copy link
Owner

marvk commented Jan 30, 2022

Without having had a look at the code, what you describe is what is supposed to happen. Thanks for the report, I'm going to have to have a look at this.

marvk added a commit that referenced this issue Mar 31, 2022
@marvk
Copy link
Owner

marvk commented Mar 31, 2022

Please do test if this issue is fixed on 0.3.5-beta.1 and if the rest of the controller name matching is still working 🙂

@PaulWalkerUK
Copy link
Author

Thanks, I'll give it a test...

@PaulWalkerUK
Copy link
Author

I think this is working as expected now. Yesterday I saw LON_CTR online, and this was correctly matching up to the whole EGTT. Now, LON_N_CTR is online and that's correctly matching to EGTT-N.

(p.s. I like the CATprism loading screen! 😸 )

@marvk marvk closed this as completed in 944df9d Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants