Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heap goes down when receiving messages with qos >0 #226

Closed
luebbe opened this issue Feb 10, 2021 · 6 comments
Closed

Heap goes down when receiving messages with qos >0 #226

luebbe opened this issue Feb 10, 2021 · 6 comments

Comments

@luebbe
Copy link
Collaborator

luebbe commented Feb 10, 2021

tested with develop FullyFeatured-ESP8266 example. Added a Serial.println(ESP.getFreeHeap()); to the end of onMqttMessage(..)
mosquitto on raspberry
MQTT Explorer on windows

Independent of the message size, the reported FreeHeap goes down with every received message
QoS 2: 40-200 Bytes
QoS 1: 20-60 Bytes
QoS 0: 16 Bytes for the first message, 0 Bytes for following QoS 0 messages if you send "rapidly", e.g. 1/second. 16 Bytes again, when you wait a few seconds.

@bertmelis
Copy link
Contributor

Didn't see this but I'm not arguing; there has been a lot of changes.

I'm very scarce of free time the next week so I can't do deep bug hunting.

@Pablo2048
Copy link
Contributor

I can confirm this - Testing with QoS 1 messages. Latest version without this heap decrease is 97d681f ...

@bertmelis bertmelis mentioned this issue Feb 11, 2021
bertmelis added a commit that referenced this issue Feb 11, 2021
@bertmelis
Copy link
Contributor

I can confirm this - Testing with QoS 1 messages. Latest version without this heap decrease is 97d681f ...

I changed something that wasn't meant to be changed when doing TLS. I can't reproduce now (I did very limited testing though).

@Pablo2048
Copy link
Contributor

Great. Seems to be fixed (at least for me...). Thanks.

@luebbe
Copy link
Collaborator Author

luebbe commented Feb 11, 2021

Thanks @bertmelis. Will test again this evening

@luebbe
Copy link
Collaborator Author

luebbe commented Feb 12, 2021

Fixed for me.

@luebbe luebbe closed this as completed Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants