Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the message splitting on Client.say #112

Merged
merged 1 commit into from
Oct 25, 2012
Merged

Fixed the message splitting on Client.say #112

merged 1 commit into from
Oct 25, 2012

Conversation

Pumpuli
Copy link
Contributor

@Pumpuli Pumpuli commented Oct 25, 2012

Client.send expects the parameters to be strings but here messagePart is returned by RegExp.exec which returns the match object.

martynsmith added a commit that referenced this pull request Oct 25, 2012
@martynsmith
Merge pull request #112 from Pumpuli/fix_message_split
ddf0507 
Fixed the message splitting on Client.say
@martynsmith martynsmith merged commit ddf0507 into martynsmith:master Oct 25, 2012
@martynsmith
Copy link
Owner

Thanks for spotting and fixing that so quickly :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pumpuli @martynsmith