fix CMake compiler detection #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martty
reviewed
Nov 30, 2024
CMakeLists.txt
Outdated
| if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang") | ||
| if(CMAKE_CXX_COMPILER_FRONTEND_VARIANT STREQUAL "GNU") | ||
| set(VUK_COMPILER_CLANGPP ON) | ||
| elseif(CMAKE_CXX_COMPILER_FRONTEND_VARINT STREQUAL "MSVC") |
When compiling on Linux, CMake may use the `c++` compiler, which usually defaults to GNU g++, and set the CMAKE_CXX_COMPILER variable accordingly. The current method fails to recognise the compiler being used and does not set appropriate options. The CMAKE_CXX_COMPILER_ID variable correctly recognises the compiler vendor.
6119a13 to
984270e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling on Linux, CMake may use the
c++compiler, which usually defaults to GNU g++, and set the CMAKE_CXX_COMPILER variable accordingly. The current method fails to recognise the compiler being used and does not set appropriate options.The CMAKE_CXX_COMPILER_ID variable correctly recognises the compiler vendor.