Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Nordigen): bring back file override #70

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix(Nordigen): bring back file override #70

merged 1 commit into from
Mar 11, 2024

Conversation

martinohansen
Copy link
Owner

This commit brings back the ability to override the requisition file used by Nordigen. Allowing the user to have multiple req. files inside the same data directory.

Fixes #69

@martinohansen
fix(Nordigen): bring back file override
bb5cc68 
This commit brings back the ability to override the requisition file
used by Nordigen. Allowing the user to have multiple req. files inside
the same data directory.

Fixes #69
@martinohansen martinohansen mentioned this pull request Mar 11, 2024
Closed
hpernu
hpernu approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@hpernu hpernu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think this works. However, a test for parameters would be appreciated regardless. ( For other parameters as well. ) This way, we at least have to update the tests if there is a parameter change making it more intentional.

@martinohansen martinohansen merged commit 7f8c6dd into main Mar 11, 2024
2 checks passed
@martinohansen martinohansen deleted the martin/fix-69 branch March 11, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hpernu hpernu hpernu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ynabber no longer honors NORDIGEN_DATAFILE environment variable
2 participants
@martinohansen @hpernu