Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nullable reference types #222

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented Apr 28, 2021

Annotate all potentially nullable reference types accordingly

Annotate all potentially nullable reference types accordingly
@0xced 0xced force-pushed the nullable-reference-types branch from 89252c8 to d439447 Compare April 28, 2021 08:53
Copy link
Owner

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - thanks @0xced!

@martincostello martincostello added the enhancement New feature or request label Apr 28, 2021
@martincostello martincostello added this to the v0.1.2 milestone Apr 28, 2021
@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #222 (d439447) into main (a3cd439) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #222   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files           8        8           
  Lines         342      342           
=======================================
  Hits          339      339           
  Misses          3        3           
Flag Coverage Δ
linux 99.12% <100.00%> (+0.87%) ⬆️
macos 99.12% <100.00%> (ø)
windows 99.12% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Logging.XUnit/XUnitLoggerExtensions.cs 100.00% <ø> (ø)
...c/Logging.XUnit/AmbientTestOutputHelperAccessor.cs 100.00% <100.00%> (ø)
src/Logging.XUnit/TestOutputHelperAccessor.cs 100.00% <100.00%> (ø)
src/Logging.XUnit/XUnitLogScope.cs 100.00% <100.00%> (ø)
src/Logging.XUnit/XUnitLogger.cs 98.05% <100.00%> (ø)
src/Logging.XUnit/XUnitLoggerOptions.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3cd439...d439447. Read the comment docs.

@martincostello martincostello merged commit b560fc2 into martincostello:main Apr 28, 2021
@martincostello
Copy link
Owner

@0xced Would you mind trying out the prerelease build from MyGet with your change in your project(s) and check you're happy with the changes? If so, I'll push 0.1.2 to NuGet.org.

https://www.myget.org/feed/martincostello/package/nuget/MartinCostello.Logging.XUnit/0.1.2-beta0206

@0xced 0xced deleted the nullable-reference-types branch April 28, 2021 12:52
@0xced
Copy link
Contributor Author

0xced commented Apr 28, 2021

Actually, I'm not using this package, yet! I was planing another pull requests (support for IMessageSink in additino to ITestOutputHelper) and I thought it was safer to enable null reference types first. 😉

@martincostello
Copy link
Owner

Ah nice. In that case (unless it's going to be a very long time), I'll wait for that and the changes can go together 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants