-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable nullable reference types #222
Enable nullable reference types #222
Conversation
Annotate all potentially nullable reference types accordingly
89252c8
to
d439447
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great - thanks @0xced!
Codecov Report
@@ Coverage Diff @@
## main #222 +/- ##
=======================================
Coverage 99.12% 99.12%
=======================================
Files 8 8
Lines 342 342
=======================================
Hits 339 339
Misses 3 3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@0xced Would you mind trying out the prerelease build from MyGet with your change in your project(s) and check you're happy with the changes? If so, I'll push 0.1.2 to NuGet.org. https://www.myget.org/feed/martincostello/package/nuget/MartinCostello.Logging.XUnit/0.1.2-beta0206 |
Actually, I'm not using this package, yet! I was planing another pull requests (support for |
Ah nice. In that case (unless it's going to be a very long time), I'll wait for that and the changes can go together 🙂 |
Annotate all potentially nullable reference types accordingly