Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Facebook login #2407

Merged
merged 1 commit into from
May 5, 2024
Merged

Remove Facebook login #2407

merged 1 commit into from
May 5, 2024

Conversation

martincostello
Copy link
Owner

Facebook requires apps to be associated with businesses now, and I'm not a business, so bye-bye Facebook login 👋.

Facebook requires apps to be associated with businesses now, and I'm not a business, so bye-bye Facebook login 👋.
@martincostello martincostello enabled auto-merge (rebase) May 5, 2024 14:06
Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.40%. Comparing base (b051638) to head (7ef516d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2407      +/-   ##
==========================================
- Coverage   79.46%   79.40%   -0.06%     
==========================================
  Files         147      147              
  Lines        3053     3045       -8     
  Branches      482      481       -1     
==========================================
- Hits         2426     2418       -8     
  Misses        421      421              
  Partials      206      206              
Flag Coverage Δ
linux 79.40% <ø> (-0.06%) ⬇️
macos 79.40% <ø> (-0.06%) ⬇️
windows 79.69% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@costellobot costellobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop https://localhost:50001

Device URL
mobile https://localhost:50001

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@martincostello martincostello merged commit 6cfb320 into main May 5, 2024
11 checks passed
@martincostello martincostello deleted the remove-facebook-login branch May 5, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants