Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround #2406

Closed
wants to merge 2 commits into from
Closed

Remove workaround #2406

wants to merge 2 commits into from

Conversation

martincostello
Copy link
Owner

Remove workaround for bug fixed in .NET 8.0.400 SDK.

Remove workaround for bug fixed in .NET 8.0.400 SDK.
@martincostello martincostello added enhancement .NET Pull requests that update .net code labels May 4, 2024
Copy link
Collaborator

@costellobot costellobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop https://localhost:50001

Device URL
mobile https://localhost:50001

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.29%. Comparing base (b1ee8f8) to head (3861a2e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2406      +/-   ##
==========================================
- Coverage   78.36%   78.29%   -0.07%     
==========================================
  Files         129      129              
  Lines        2616     2599      -17     
  Branches      399      397       -2     
==========================================
- Hits         2050     2035      -15     
+ Misses        382      381       -1     
+ Partials      184      183       -1     
Flag Coverage Δ
linux 78.29% <ø> (-0.07%) ⬇️
macos 78.29% <ø> (-0.07%) ⬇️
windows 79.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello
Copy link
Owner Author

@costellobot rebase

@martincostello martincostello marked this pull request as ready for review August 13, 2024 17:17
@martincostello martincostello deleted the remove-workaround branch August 13, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants