Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Windows deployment #2386

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Remove Windows deployment #2386

merged 2 commits into from
Apr 29, 2024

Conversation

martincostello
Copy link
Owner

Remove deployment as a Windows application, leaving only Linux containers.

Remove deployment as a Windows application, leaving only Linux containers.
@martincostello martincostello added enhancement github_actions Pull requests that update GitHub Actions code labels Apr 29, 2024
@martincostello martincostello enabled auto-merge (rebase) April 29, 2024 08:47
Copy link
Collaborator

@costellobot costellobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop https://localhost:50001

Device URL
mobile https://localhost:50001

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.57%. Comparing base (fa318c1) to head (c44b0a0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2386   +/-   ##
=======================================
  Coverage   79.57%   79.57%           
=======================================
  Files         147      147           
  Lines        3050     3050           
  Branches      481      481           
=======================================
  Hits         2427     2427           
  Misses        417      417           
  Partials      206      206           
Flag Coverage Δ
linux 79.57% <ø> (ø)
macos 79.57% <ø> (ø)
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Don't use PowerShell in bash...
@martincostello martincostello merged commit 2cb0a6e into main Apr 29, 2024
14 checks passed
@martincostello martincostello deleted the remove-windows-deploy branch April 29, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants