Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CodeQL warnings #2375

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Fix CodeQL warnings #2375

merged 1 commit into from
Apr 25, 2024

Conversation

martincostello
Copy link
Owner

Fix two new CodeQL warnings.

Fix two new CodeQL warnings.
@martincostello martincostello added enhancement .NET Pull requests that update .net code labels Apr 25, 2024
@martincostello martincostello enabled auto-merge (rebase) April 25, 2024 15:50
Copy link
Collaborator

@costellobot costellobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop https://localhost:50001

Device URL
mobile https://localhost:50001

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.35%. Comparing base (e89f7be) to head (bb599af).

Files Patch % Lines
.../LondonTravel.Site/Controllers/ManageController.cs 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2375      +/-   ##
==========================================
+ Coverage   79.33%   79.35%   +0.02%     
==========================================
  Files         147      147              
  Lines        2995     2994       -1     
  Branches      478      478              
==========================================
  Hits         2376     2376              
+ Misses        415      414       -1     
  Partials      204      204              
Flag Coverage Δ
linux 79.35% <80.00%> (+0.02%) ⬆️
macos 79.35% <80.00%> (+0.02%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit 6fffb29 into main Apr 25, 2024
13 checks passed
@martincostello martincostello deleted the fix-codeql-warnings branch April 25, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants