Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenTelemetry #2374

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Add OpenTelemetry #2374

merged 2 commits into from
Apr 25, 2024

Conversation

martincostello
Copy link
Owner

  • Add OpenTelemetry.
  • Remove explicit usage of Application Insights.
  • Remove Serilog.
  • Log Polly at warning level.
  • Prepare to adopt .NET Aspire by changing the Cosmos client to use a connection string.
  • Fix local development using a region, which doesn't work with the emulator.
  • Minor "linting" tidying up.
  • Remove "Azure:Datacenter" as the application hasn't been hosted in multiple ones for a long time.

- Add OpenTelemetry.
- Remove explicit usage of Application Insights.
- Remove Serilog.
- Log Polly at warning level.
- Prepare to adopt .NET Aspire by changing the Cosmos client to use a connection string.
- Fix local development using a region, which doesn't work with the emulator.
- Minor "linting" tidying up.
- Remove "Azure:Datacenter" as the application hasn't been hosted in multiple ones for a long time.
@martincostello martincostello added enhancement dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code .NET Pull requests that update .net code labels Apr 25, 2024
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 85.98131% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 79.33%. Comparing base (c57addb) to head (0cc28af).

Files Patch % Lines
...ondonTravel.Site/Extensions/TelemetryExtensions.cs 89.04% 4 Missing and 4 partials ⚠️
...onTravel.Site/Extensions/IHostBuilderExtensions.cs 0.00% 2 Missing and 2 partials ⚠️
...ravel.Site/Extensions/ILoggingBuilderExtensions.cs 75.00% 1 Missing and 1 partial ⚠️
...l.Site/Identity/AuthenticationBuilderExtensions.cs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2374      +/-   ##
==========================================
+ Coverage   79.16%   79.33%   +0.16%     
==========================================
  Files         148      147       -1     
  Lines        3053     2995      -58     
  Branches      489      478      -11     
==========================================
- Hits         2417     2376      -41     
+ Misses        426      415      -11     
+ Partials      210      204       -6     
Flag Coverage Δ
linux 79.33% <85.98%> (+0.16%) ⬆️
macos 79.33% <85.98%> (+0.16%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Update configuration so the site loads.
Copy link
Collaborator

@costellobot costellobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop https://localhost:50001

Device URL
mobile https://localhost:50001

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@martincostello martincostello enabled auto-merge (squash) April 25, 2024 15:11
@martincostello martincostello merged commit e89f7be into main Apr 25, 2024
13 checks passed
@martincostello martincostello deleted the add-otel branch April 25, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement javascript Pull requests that update Javascript code .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants