Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ASP.NET Core 9 #2177

Merged
merged 17 commits into from
Sep 11, 2024
Merged

Update to ASP.NET Core 9 #2177

merged 17 commits into from
Sep 11, 2024

Conversation

martincostello
Copy link
Owner

@martincostello martincostello commented Feb 13, 2024

  • Update to ASP.NET Core 9.
  • Migrate from Swashbuckle.AspNetCore to Microsoft.AspNetCore.OpenApi.
  • Fix/suppress new code analysis warnings.

@martincostello martincostello added enhancement dependencies Pull requests that update a dependency file .NET Pull requests that update .net code labels Feb 13, 2024
Copy link
Collaborator

@costellobot costellobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop https://localhost:50001

Device URL
mobile https://localhost:50001

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.00%. Comparing base (fca574d) to head (a99435f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/LondonTravel.Site/OpenApi/AddApiInfo.cs 80.00% 0 Missing and 5 partials ⚠️
src/LondonTravel.Site/OpenApi/AddSecurity.cs 88.88% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2177      +/-   ##
==========================================
- Coverage   78.20%   78.00%   -0.20%     
==========================================
  Files         129      122       -7     
  Lines        2601     2501     -100     
  Branches      399      381      -18     
==========================================
- Hits         2034     1951      -83     
+ Misses        381      366      -15     
+ Partials      186      184       -2     
Flag Coverage Δ
linux 78.00% <88.88%> (-0.20%) ⬇️
macos 78.00% <88.88%> (-0.20%) ⬇️
windows 78.76% <88.33%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello force-pushed the dotnet-vnext branch 2 times, most recently from 96286d8 to d50ec5a Compare February 16, 2024 12:00
@martincostello martincostello force-pushed the dotnet-vnext branch 2 times, most recently from 5b23132 to eff2d91 Compare March 7, 2024 10:34
@martincostello martincostello force-pushed the dotnet-vnext branch 3 times, most recently from 0318623 to b7da9b4 Compare April 10, 2024 08:44
@martincostello martincostello force-pushed the dotnet-vnext branch 2 times, most recently from 6c591bd to 193220b Compare April 19, 2024 12:28
@martincostello martincostello force-pushed the dotnet-vnext branch 4 times, most recently from 1f6a7b2 to 08d49e9 Compare April 30, 2024 13:29
@martincostello martincostello force-pushed the dotnet-vnext branch 2 times, most recently from 7ee0a17 to 7861c5d Compare May 7, 2024 21:36
@martincostello martincostello force-pushed the dotnet-vnext branch 6 times, most recently from 4b189b7 to 4601641 Compare May 21, 2024 18:08
@martincostello martincostello force-pushed the dotnet-vnext branch 4 times, most recently from 2cfb3d1 to 7c65d13 Compare September 10, 2024 06:37
@martincostello
Copy link
Owner Author

/deploy

Copy link

github-actions bot commented Sep 11, 2024

Deployment to dev failed ❌

@martincostello
Copy link
Owner Author

@costellobot rebase

martincostello and others added 17 commits September 11, 2024 10:41
- Update to ASP.NET Core 9 using preview 6.
- Use new `Convert.ToHexStringLower()` API.
- Replace Swashbuckle.AspNetCore with Microsoft.AspNetCore.OpenApi.
Use MartinCostello.OpenApi.Extensions NuGet package to extend OpenAPI document.
- Use preview builds of MartinCostello.OpenApi.Extensions from feedz.io.
- Use metadata methods for OpenAPI responses.
Update to the latest version of MartinCostello.OpenApi.Extensions compatible with .NET 9 preview 6.
Fix rebase that removed `type` property.
Add output caching to the OpenAPI endpoint.
Update to preview 7 of ASP.NET Core 9.
Re-enable skipped test.
Update to the latest 9.0.0 release of Microsoft.DotNet.XliffTasks.
Update NuGet package for .NET 9 preview 7.
Fix incorrect rebase.
React to breaking change in Microsoft.OpenApi v1.6.20.
Revert back to using the latest version of C# instead of preview.
* Update .NET SDK

Update .NET SDK to version 9.0.100-rc.1.24452.12.

---
updated-dependencies:
- dependency-name: Microsoft.NET.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com>

* Bump .NET NuGet packages

Bumps .NET dependencies to their latest versions for the .NET 9.0.100-rc.1.24452.12 SDK.

Bumps AspNet.Security.OAuth.Amazon from 9.0.0-preview.7.24413.60 to 9.0.0-preview.7.24459.55.
Bumps AspNet.Security.OAuth.Apple from 9.0.0-preview.7.24413.60 to 9.0.0-preview.7.24459.55.
Bumps AspNet.Security.OAuth.GitHub from 9.0.0-preview.7.24413.60 to 9.0.0-preview.7.24459.55.

---
updated-dependencies:
- dependency-name: AspNet.Security.OAuth.Amazon
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: AspNet.Security.OAuth.Apple
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: AspNet.Security.OAuth.GitHub
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com>

* Update NuGet packages
Update NuGet packages for RC1.

---------

Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com>
Co-authored-by: Martin Costello <martin@martincostello.com>
Bump Microsoft.Extensions.Http.Resilience to latest version.
Add workaround for native AoT deployment issue.
Remove suppression for CS9057.
@martincostello
Copy link
Owner Author

/deploy

Copy link

github-actions bot commented Sep 11, 2024

🧪 Tests for deployment to dev passed ✅

@martincostello martincostello marked this pull request as ready for review September 11, 2024 10:55
@martincostello martincostello merged commit 50d5724 into main Sep 11, 2024
14 of 15 checks passed
@martincostello martincostello deleted the dotnet-vnext branch September 11, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants