Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ConfigureHttpClientDefaults() #2157

Closed
wants to merge 2 commits into from

Conversation

martincostello
Copy link
Owner

Disable ConfigureHttpClientDefaults() until the issue with it is resolved in .NET 8.0.2.

Disable `ConfigureHttpClientDefaults()` until the issue with it is resolved in .NET 8.0.2.
@martincostello martincostello added bug .NET Pull requests that update .net code labels Feb 1, 2024
@martincostello martincostello enabled auto-merge (rebase) February 1, 2024 22:08
Need to add the unnamed client too.
Copy link
Collaborator

@costellobot costellobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop https://localhost:50001

Device URL
mobile https://localhost:50001

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c8e6495) 79.29% compared to head (b257309) 79.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2157      +/-   ##
==========================================
+ Coverage   79.29%   79.31%   +0.01%     
==========================================
  Files         148      148              
  Lines        3072     3074       +2     
  Branches      495      495              
==========================================
+ Hits         2436     2438       +2     
  Misses        425      425              
  Partials      211      211              
Flag Coverage Δ
linux 79.31% <100.00%> (+0.01%) ⬆️
macos ?
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

auto-merge was automatically disabled February 1, 2024 22:18

Pull request was closed

@martincostello martincostello deleted the Disable-ConfigureHttpClientDefaults branch February 1, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants