Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Microsoft.Extensions.Http.Resilience #2024

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

martincostello
Copy link
Owner

Use the Microsoft.Extensions.Http.Resilience library.

Use the Microsoft.Extensions.Http.Resilience library.
@martincostello martincostello added enhancement dependencies Pull requests that update a dependency file .NET Pull requests that update .net code labels Nov 6, 2023
@martincostello martincostello enabled auto-merge (rebase) November 6, 2023 15:18
Copy link
Collaborator

@costellobot costellobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop https://localhost:5001

Device URL
mobile https://localhost:5001

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5dc4c38) 79.10% compared to head (b1ac287) 78.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2024      +/-   ##
==========================================
- Coverage   79.10%   78.91%   -0.19%     
==========================================
  Files         153      152       -1     
  Lines        3235     3206      -29     
  Branches      509      507       -2     
==========================================
- Hits         2559     2530      -29     
  Misses        464      464              
  Partials      212      212              
Flag Coverage Δ
linux 78.91% <100.00%> (-0.19%) ⬇️
macos 78.91% <100.00%> (-0.19%) ⬇️
windows 78.91% <100.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...Site/Extensions/HttpServiceCollectionExtensions.cs 93.75% <100.00%> (+0.64%) ⬆️
...el.Site/Extensions/IHttpClientBuilderExtensions.cs 93.75% <100.00%> (-0.54%) ⬇️
src/LondonTravel.Site/Program.cs 77.38% <ø> (-0.14%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit 0933e14 into main Nov 6, 2023
12 checks passed
@martincostello martincostello deleted the use-resilience-library branch November 6, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants