Bump the xunit group with 2 updates (#2050)

* Bump the xunit group with 2 updates

Bumps the xunit group with 2 updates: [xunit](https://github.com/xunit/xunit) and [xunit.runner.visualstudio](https://github.com/xunit/visualstudio.xunit).


Updates `xunit` from 2.6.1 to 2.6.2
- [Commits](xunit/xunit@2.6.1...2.6.2)

Updates `xunit.runner.visualstudio` from 2.5.3 to 2.5.4
- [Release notes](https://github.com/xunit/visualstudio.xunit/releases)
- [Commits](xunit/visualstudio.xunit@2.5.3...2.5.4)

---
updated-dependencies:
- dependency-name: xunit
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: xunit
- dependency-name: xunit.runner.visualstudio
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: xunit
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix build

Fix xUnit1012 warnings.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: martincostello <martin@martincostello.com>

Directory.Packages.props

@@ -45,8 +45,8 @@
     <PackageVersion Include="Swashbuckle.AspNetCore" Version="$(SwashbuckleAspNetCoreVersion)" />
     <PackageVersion Include="Swashbuckle.AspNetCore.Annotations" Version="$(SwashbuckleAspNetCoreVersion)" />
     <PackageVersion Include="xRetry" Version="1.9.0" />
-    <PackageVersion Include="xunit" Version="2.6.1" />
-    <PackageVersion Include="xunit.runner.visualstudio" Version="2.5.3" />
+    <PackageVersion Include="xunit" Version="2.6.2" />
+    <PackageVersion Include="xunit.runner.visualstudio" Version="2.5.4" />
     <PackageVersion Include="Xunit.SkippableFact" Version="1.4.13" />
   </ItemGroup>
   <ItemGroup>

tests/LondonTravel.Site.Tests/Integration/ApiTests.cs

@@ -25,7 +25,7 @@ public class ApiTests(TestServerFixture fixture, ITestOutputHelper outputHelper)
     [InlineData(null)]
     [InlineData("")]
     [InlineData(" ")]
-    public async Task Cannot_Get_Preferences_Unauthenticated(string value)
+    public async Task Cannot_Get_Preferences_Unauthenticated(string? value)
     {
         // Arrange
         using var client = Fixture.CreateClient();

tests/LondonTravel.Site.Tests/Services/AlexaServiceTests.cs

@@ -68,7 +68,7 @@ public async Task AuthorizeSkill_Returns_Not_Found_If_Account_Linking_Disabled()
     [Theory]
     [InlineData(null)]
     [InlineData("")]
-    public async Task AuthorizeSkill_Returns_Correct_Location_If_Client_Id_Is_Invalid(string clientId)
+    public async Task AuthorizeSkill_Returns_Correct_Location_If_Client_Id_Is_Invalid(string? clientId)
     {
         // Arrange
         string state = "Some State";
@@ -120,7 +120,7 @@ await AssertRedirect(
     [Theory]
     [InlineData(null)]
     [InlineData("")]
-    public async Task AuthorizeSkill_Returns_Correct_Location_If_Response_Type_Is_Invalid(string responseType)
+    public async Task AuthorizeSkill_Returns_Correct_Location_If_Response_Type_Is_Invalid(string? responseType)
     {
         // Arrange
         string state = "Some State";
@@ -176,7 +176,7 @@ await AssertRedirect(
     [InlineData("http://alexa.amazon.com/alexa-london-travel/?foo=baz")]
     [InlineData("https://alexa.amazon.com/alexa-london-travel/unknown")]
     [InlineData("https://bbc.co.uk")]
-    public async Task AuthorizeSkill_Returns_Bad_Request_If_Redirect_Uri_Is_Invalid(string redirectUrl)
+    public async Task AuthorizeSkill_Returns_Bad_Request_If_Redirect_Uri_Is_Invalid(string? redirectUrl)
     {
         // Arrange
         string state = "Some State";
@@ -262,7 +262,7 @@ await AssertRedirect(
     [Theory]
     [InlineData(null)]
     [InlineData("My Existing Token")]
-    public async Task AuthorizeSkill_Returns_Correct_Redirect_Url_If_Token_Created_Or_Updated(string alexaToken)
+    public async Task AuthorizeSkill_Returns_Correct_Redirect_Url_If_Token_Created_Or_Updated(string? alexaToken)
     {
         // Arrange
         string state = "Some State";
@@ -312,6 +312,7 @@ public async Task AuthorizeSkill_Returns_Correct_Redirect_Url_If_Token_Created_O
             url.ShouldNotContain(Uri.EscapeDataString(alexaToken));
         }
 
+        user.AlexaToken.ShouldNotBeNull();
         user.AlexaToken.ShouldNotBe(alexaToken);
         user.AlexaToken.Length.ShouldBeGreaterThanOrEqualTo(64);
     }

tests/LondonTravel.Site.Tests/Services/Data/DocumentHelpersTests.cs

@@ -83,7 +83,7 @@ public static void CreateClient_Throws_If_Options_Has_Relative_Service_Endpoint(
     [Theory]
     [InlineData(null)]
     [InlineData("")]
-    public static void CreateClient_Throws_If_Options_Has_No_Access_Key(string accessKey)
+    public static void CreateClient_Throws_If_Options_Has_No_Access_Key(string? accessKey)
     {
         // Arrange
         var options = new UserStoreOptions()
@@ -103,7 +103,7 @@ public static void CreateClient_Throws_If_Options_Has_No_Access_Key(string acces
     [Theory]
     [InlineData(null)]
     [InlineData("")]
-    public static void CreateClient_Throws_If_Options_Has_No_Database_Name(string databaseName)
+    public static void CreateClient_Throws_If_Options_Has_No_Database_Name(string? databaseName)
     {
         // Arrange
         var options = new UserStoreOptions()
@@ -123,7 +123,7 @@ public static void CreateClient_Throws_If_Options_Has_No_Database_Name(string da
     [Theory]
     [InlineData(null)]
     [InlineData("")]
-    public static void CreateClient_Throws_If_Options_Has_No_Collection_Name(string collectionName)
+    public static void CreateClient_Throws_If_Options_Has_No_Collection_Name(string? collectionName)
     {
         // Arrange
         var options = new UserStoreOptions()