Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update update-tolgee.yml: Run every Monday #3247

Closed
wants to merge 1 commit into from

Conversation

Saibamen
Copy link
Contributor

@Saibamen Saibamen commented Feb 3, 2025

Reduce git pull requests and commits

Reduce git pull requests and commits
@marticliment
Copy link
Owner

Why?

@Saibamen
Copy link
Contributor Author

Saibamen commented Feb 3, 2025

To reduce pull requests you need to merge and to reduce commits in changelog view/latest commits view.

Right now there are 261 commits between 3.1.5 and 3.1.6-beta3: 3.1.5...3.1.6-beta3

And 30 of them are for translations. Lot of them are only updating one or two languages.

@marticliment
Copy link
Owner

marticliment commented Feb 3, 2025

And 30 of them are for translations. Lot of them are only updating one or two languages.

Yes, but updated translations take effect on already published versions of UniGetUI. Therefore, by decreasing the amount of PRs the changes would take much longer to be effective.

Once a PR is merged, UniGetUI will pull new translations from GitHub

@Saibamen
Copy link
Contributor Author

Saibamen commented Feb 3, 2025

Once a PR is merged, UniGetUI will pull new translations from GitHub

Ahh ok. Translations are not included in UnigetUI source code, but downloaded from GH and cached on local disk.

@Saibamen Saibamen closed this Feb 3, 2025
@marticliment
Copy link
Owner

marticliment commented Feb 4, 2025

Yes, exactly (although a backup is included on source code in case the device fails to download translations)

@Saibamen Saibamen deleted the patch-1 branch February 4, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants