Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add writeOnly and nullable to _VALID_PROPERTIES list #684

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Add writeOnly and nullable to _VALID_PROPERTIES list #684

merged 1 commit into from
Jun 28, 2021

Conversation

greyli
Copy link
Contributor

@greyli greyli commented Jun 25, 2021 •
edited
Loading

The nullable and writeOnly are supported but not in the _VALID_PROPERTIES list. This PR also adds tests for readOnly and writeOnly.

P.S. I also found the metadata accepts "doc_default", is it a deprecated value (since we already have default)?

@greyli greyli mentioned this pull request Jun 25, 2021
Merged
3 tasks
@lafrech lafrech merged commit 1096289 into marshmallow-code:dev Jun 28, 2021
@lafrech
Copy link
Member

lafrech commented Jun 28, 2021

Thanks.

Regarding doc_default, see #196. But thanks for the heads up because since metadata is namespaced in marshmallow, the doc_default thing shouldn't be necessary. We shall remove it in apispec 5 (#687).

@greyli greyli deleted the ma-metadata branch June 28, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greyli @lafrech