Implement source instead of cause on std::error::Error types
#243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `cause` method has been deprecated since Rust 1.33.0 and has been replaced by `source`. The `cause` method's default implementation calls `source` so there is no need to implement them both. On types which always return `None` in `source`, the implementation has been removed because the default implementation does exactly this.
|
Thanks for the contribution. I'll be releasing a new version shortly, and this will be included. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
causemethod has been deprecated since Rust 1.33.0 and has been replaced bysource. Thecausemethod's default implementation callssourceso there is no need to implement them both.On types which always return
Noneinsource, the implementation has been removed because the default implementation does exactly this.