Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, use
[T]::chunks
rather than doing index calculationmanually.
Secondly, get rid of max_input_length. The function was overly
complicated for no reason. After all, no matter whether engine uses
padding or not, N-byte output buffer can accommodate (N/4*3) input
bytes.
Encode benchmarks here are kind of all over. Some improvements and
some regressions: