Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data attributes to the HTML if options are passed via javascript #3

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

nkdas91
Copy link
Member

@nkdas91 nkdas91 commented Nov 18, 2022

Description

Add data attributes to the HTML if options are passed via javascript

Motivation & Context

Fixes #2

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly

Related issues

#2

@nkdas91 nkdas91 added the bug Something isn't working label Nov 18, 2022
@nkdas91 nkdas91 self-assigned this Nov 18, 2022
@nkdas91 nkdas91 merged commit 882dbc6 into main Nov 18, 2022
@nkdas91 nkdas91 deleted the feature branch November 18, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Unable to set marquee direction via Javascript
1 participant