Test for README examples (weighted queries & multimodal combinations) #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
pandu-k
approved these changes
Mar 30, 2023
|
Have all tests been run? If so, feel free to merge |
1 similar comment
|
Have all tests been run? If so, feel free to merge |
|
Yep - all test run and pass. I will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two tests, one for weighted queries and one for multimodal combination fields - these are in the readme for the main marqo repo.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Tests for docs update in Readme examples new features marqo#403
What is the current behavior? (You can also link to an open issue here)
There are no tests for the new examples
What is the new behavior (if this is a feature change)?
N/A
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information: