Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for 2.10 release #242

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Fix tests for 2.10 release #242

merged 2 commits into from
Jul 10, 2024

Conversation

wanliAlex
Copy link
Collaborator

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Test fix

  • What is the current behavior? (You can also link to an open issue here)

    1. We don't have no-model end-to-end tests
    1. PY-Marqo tries to decode it as JSON and gets an error when the response isn't JSON
    1. Version check tests are not working properly
  • What is the new behavior (if this is a feature change)?
    1. Add no-model end-to-end tests
    1. Fix a bug where PY-Marqo tries to decode it as JSON and gets an error when the response isn't JSON
    1. Fix a bug where version check tests are not working properly
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@farshidz farshidz merged commit 5ee1ec3 into mainline Jul 10, 2024
4 of 5 checks passed
@farshidz farshidz deleted the li/patch-2.10 branch July 10, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants