Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inferenceType typo in cloud integ tests #237

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

VitusAcabado
Copy link
Contributor

@VitusAcabado VitusAcabado commented Jun 4, 2024

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Fix Integ test input typo

  • What is the current behavior? (You can also link to an open issue here)
    After Cloud validation changes, typo causes error returned. Previously it passes because we have an assumed default.

  • What is the new behavior (if this is a feature change)?
    Input will be accepted

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:

@VitusAcabado VitusAcabado marked this pull request as ready for review June 4, 2024 00:30
@VitusAcabado VitusAcabado changed the title fix inferenceType typo fix inferenceType typo in cloud integ tests Jun 4, 2024
@VitusAcabado VitusAcabado temporarily deployed to py-marqo-test-suite June 4, 2024 00:31 — with GitHub Actions Inactive
@VitusAcabado VitusAcabado merged commit 70283fe into mainline Jun 4, 2024
4 of 5 checks passed
@VitusAcabado VitusAcabado deleted the vitus/fix-cloud-tests-input branch June 4, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants