Danyil/fix cloud cleanup #216
Conversation
| unstructured_text_custom_prepro = "unstr_txt_custom_prepro" | ||
| unstructured_text = "pymarqo_unstr_txt" | ||
| unstructured_image = "pymarqo_unstr_img" | ||
| unstructured_text_custom_prepro = "pymarqo_unstr_txt_custom_prepro" |
There was a problem hiding this comment.
Is this index created during the test? There is a restriction on the length of the index name (32 chars). Note we add 4 chars as unique identifiers in addition to this string
There was a problem hiding this comment.
This one is actually not used anywhere and it just needs to be renamed.
There was a problem hiding this comment.
Can you make sure this index can be created correctly and the custom model can be used? Because this is related to custom models which is kind of important.
There was a problem hiding this comment.
I could add it and add another test but it will force us to have 4 indexes created per test execution. @pandu-k should we do it?
There was a problem hiding this comment.
custom models are an important use case. Ideally we find a way to make it work with the current indexes, but if we need to add a new index for this to work we can do that too.
Tbh when we fix this, this test should be extended to include private (auth-required) models
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: