Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix telemetry cleanup bug (from #800) #804

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

farshidz
Copy link
Collaborator

  • Fix bug where telemetry does not clean up objects when telemetry=false

  • Add a memory profiler endpoint /memory, disabled by default and enabled through an environment variable

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Have unit tests been run against this PR? (Has there also been any additional testing?)

  • Related Python client changes (link commit/PR here)

  • Related documentation changes (link commit/PR here)

  • Other information:

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

* Fix bug where telemetry does not clean up objects when telemetry=false
* Add a memory profiler endpoint /memory, disabled by default and enabled through an environment variable
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite April 15, 2024 03:03 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite April 15, 2024 03:04 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite April 15, 2024 03:04 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite April 15, 2024 03:04 — with GitHub Actions Inactive
@wanliAlex wanliAlex merged commit 84b8822 into releases/2.2 Apr 15, 2024
14 of 15 checks passed
@wanliAlex wanliAlex deleted the farshid/telemetry-fix-2.2 branch April 15, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants