Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstructured index distance metric fix #772

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

vicilliar
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    For unstructured indexes, distance metric is set to prenormalized-angular regardless of user input.

  • What is the new behavior (if this is a feature change)?

  • Distance metric user configuration now works as expected.
  • Refactored distance metric mapping (internal)
  • Fixed typos (internal)
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    In progress

  • Related Python client changes (link commit/PR here)
    None

  • Related documentation changes (link commit/PR here)
    None

  • Other information:

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@vicilliar vicilliar merged commit e99b549 into mainline Feb 28, 2024
22 of 25 checks passed
@vicilliar vicilliar deleted the joshua/unstructured-distance-metric-fix branch February 28, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants