Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade open_clip_torch in marqo-base image #646

Merged
merged 11 commits into from
Nov 29, 2023

Conversation

vicilliar
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Package upgrade

  • What is the current behavior? (You can also link to an open issue here)
    open_clip_torch is 2.18.0

  • What is the new behavior (if this is a feature change)?
    open_clip_torch upgraded to 2.23.0

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    Yes

  • Related Python client changes (link commit/PR here)
    None

  • Related documentation changes (link commit/PR here)
    None

  • Other information:
    Will be changed when marqo-base open_clip upgrade gets merged into mainline and pushed as the next version. Should not remain as test-open-clip-upgrade.

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@vicilliar vicilliar changed the title Upgradeopen_clip_torch in marqo-base image Upgrade open_clip_torch in marqo-base image Nov 20, 2023
@vicilliar
Copy link
Contributor Author

vicilliar commented Nov 20, 2023

Performance test runs:
Open CLIP model used: open_clip/ViT-B-32-quickgelu/laion400m_e32
#62:
Single Threaded
1.4.0 (CANDIDATE): 29.84 RPS
Upgraded open-clip-torch (REFERENCE): 29.59 RPS

5 Threads
1.4.0 (CANDIDATE): 40.48 RPS
Upgraded open-clip-torch (REFERENCE): 40.21 RPS

#63:
Single Threaded
1.4.0 (REFERENCE): 30.16 RPS
Upgraded open-clip-torch (CANDIDATE): 30.21 RPS

5 Threads
1.4.0 (REFERENCE): 40.84 RPS
Upgraded open-clip-torch (CANDIDATE): 40.98 RPS

No significant difference found in RPS with Open CLIP model.

@jn2clark
Copy link
Contributor

@vicilliar not sure but the timm package might need to also be updated/included

farshidz
farshidz previously approved these changes Nov 28, 2023
@vicilliar
Copy link
Contributor Author

Performance testing again with upgraded timm and safetensors

Candidate is marqo:test-open-clip-upgrade (64): https://github.com/marqo-ai/marqo-performance-tests/actions/runs/7028283291

Single Threaded
Upgraded open-clip-torch (CANDIDATE): 29.59 RPS
1.4.0 (REFERENCE): 29.15 RPS

5 Threads
Upgraded open-clip-torch (CANDIDATE): 40.19 RPS
1.4.0 (REFERENCE): 40.00 RPS

Candidate is marqo:1.4.0: https://github.com/marqo-ai/marqo-performance-tests/actions/runs/7028295023
Single Threaded
Upgraded open-clip-torch (REFERENCE): 27.66 RPS
1.4.0 (CANDIDATE): 28.89 RPS

5 Threads
Upgraded open-clip-torch (REFERENCE): 39.76 RPS
1.4.0 (CANDIDATE): 39.39 RPS

No significant difference found in RPS with Open CLIP model.

@vicilliar vicilliar merged commit 3aa8c74 into mainline Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants