Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add summary job to run_all_tests workflow #586

Merged
merged 5 commits into from
Aug 29, 2023
Merged

Conversation

pandu-k
Copy link
Collaborator

@pandu-k pandu-k commented Aug 24, 2023

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • CI update and bug fix

What is the current behavior? (You can also link to an open issue here)

  • run_all_tests has no summary job, which reflects if all the tests passed or failed
  • This prevents us from having a branch protection status check on this workflow.
  • We cannot put branch protection status checks on each individual test workflow because these workflows do not run for markdown-only changes. This means that markdown-only PRs will never be OK'd for merging.

What is the new behavior (if this is a feature change)?

  • There is now a summary job, which passes only if all the tests passed or were skipped. Skipping occurs iff the changes only affected markdown files.

Have unit tests been run against this PR? (Has there also been any additional testing?)

Yes. Manual tests:

We need to also check if markdown-only changes skips testing, and the test summary correctly passes. However, we need this update merged into mainline and then have a markdown-only PR into mainline approved in order to test this.

Other information

  • To rerun a failed test, restart the start-ec2-runner job that belongs to failed test workflow, not the test job itself:
    image

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@pandu-k pandu-k temporarily deployed to marqo-test-suite August 24, 2023 08:13 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite August 24, 2023 08:13 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite August 24, 2023 08:13 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite August 24, 2023 08:43 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite August 24, 2023 08:44 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite August 24, 2023 08:44 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite August 24, 2023 08:44 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite August 24, 2023 08:44 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite August 24, 2023 08:44 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite August 24, 2023 10:26 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite August 24, 2023 10:27 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite August 24, 2023 10:27 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite August 24, 2023 10:28 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite August 24, 2023 10:28 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite August 24, 2023 10:28 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite August 24, 2023 12:01 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite August 24, 2023 12:01 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite August 24, 2023 12:01 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite August 24, 2023 12:01 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite August 24, 2023 12:01 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite August 24, 2023 12:03 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite August 25, 2023 04:07 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite August 25, 2023 04:08 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite August 25, 2023 04:08 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite August 25, 2023 04:08 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite August 25, 2023 04:08 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite August 25, 2023 04:08 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite August 29, 2023 10:44 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite August 29, 2023 10:44 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite August 29, 2023 10:44 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite August 29, 2023 10:44 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite August 29, 2023 10:44 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite August 29, 2023 10:44 — with GitHub Actions Inactive
@pandu-k pandu-k merged commit 8ce8e7b into mainline Aug 29, 2023
@pandu-k pandu-k deleted the pandu/summary-workflow branch August 29, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants