Add numberOfVectors to get_stats api #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandu-k
reviewed
Jul 26, 2023
There was a problem hiding this comment.
Let's get some edge case and HTTP error tests
pandu-k
reviewed
Jul 26, 2023
| nested_doc_count = HttpRequests(config).get(path=F"{index_name}/_stats/docs")["indices"][index_name]["primaries"][ | ||
| "docs"]["count"] | ||
| vector_count = HttpRequests(config).get(path=f"{index_name}/_search", body=body) \ | ||
| ["aggregations"]["nested_chunks"]["chunk_count"]["value"] | ||
| except KeyError as e: |
There was a problem hiding this comment.
nice job catching KeyError.
You may also need to catch TypeError, if you are parsing an unknown dict
There was a problem hiding this comment.
Let's also get some cases where the HTTP response isn't expected (like an unknown dict type because of an error)
farshidz
requested changes
Jul 27, 2023
farshidz
requested changes
Jul 27, 2023
farshidz
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Add numberOfVectors to get_stats api
What is the current behavior? (You can also link to an open issue here)
we only have numberOfDocuments
What is the new behavior (if this is a feature change)?
we now have numberOfVectors attribute
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no.
Have unit tests been run against this PR? (Has there also been any additional testing?)
running
Related Python client changes (link commit/PR here)
working on
Related documentation changes (link commit/PR here)
working on
Other information:
no
Please check if the PR fulfills these requirements