single knn-field: test_search.py passes #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicilliar
added a commit
that referenced
this pull request
Jul 16, 2023
* using a single kNN opensearch field * made end-to-end case work * added debug statements for OpenSearch requests * Added brackets around combined opensearch filter * fixed bug with no searchable attributes * changed marqo version * single knn-field: test_search.py passes (#526) * made test_search pass * Updated CUDA version to match mainline * removed debug message in OS * fixed add docs, backend, create index unit tests * pagination error handling * removed debug message * fixed bulk search and search tests * fixed broken tests * fixed index meta cache tests, add knn field validation * empty results for empty searchable attr lexical * finished pagination tests * refactored filtering, get_model_properties, index creation tests * fixed generic model error tests * added knn field tests * updated filtering tests * added changes to contextualise_user_filter * filtering unit tests pass, double backslash escape fixed * added backslash escaping to Lucene sanitise function fixed tests * fixed contextualise edge cases with field at start of filter * fixed contextualise edge cases with field at start of filter * more edge cases for filtering * edge case fixed in contextualise, also added draft regex solution * fixed wrong string length skip * removed unused code, updated name of contextualise * fixed bug when content has field name by adding colon req * gitignore vscode directory * removed vscode settings json * improved function docstrings --------- Co-authored-by: Joshua Kim <joshua@marqo.ai>
wanliAlex
pushed a commit
that referenced
this pull request
Jul 17, 2023
* using a single kNN opensearch field * made end-to-end case work * added debug statements for OpenSearch requests * Added brackets around combined opensearch filter * fixed bug with no searchable attributes * changed marqo version * single knn-field: test_search.py passes (#526) * made test_search pass * Updated CUDA version to match mainline * removed debug message in OS * fixed add docs, backend, create index unit tests * pagination error handling * removed debug message * fixed bulk search and search tests * fixed broken tests * fixed index meta cache tests, add knn field validation * empty results for empty searchable attr lexical * finished pagination tests * refactored filtering, get_model_properties, index creation tests * fixed generic model error tests * Set index default replicas=0, shards=1 * added knn field tests * updated filtering tests * added changes to contextualise_user_filter * filtering unit tests pass, double backslash escape fixed * added backslash escaping to Lucene sanitise function fixed tests * fixed contextualise edge cases with field at start of filter * fixed contextualise edge cases with field at start of filter * more edge cases for filtering * testing default shards=2, replicas=0 * Removed ordering as requirement for test_lexical_search.py::TestLexicalSearch::test_lexical_search_double_quotes * edge case fixed in contextualise, also added draft regex solution * fixed wrong string length skip * removed unused code, updated name of contextualise * fixed bug when content has field name by adding colon req * gitignore vscode directory * removed vscode settings json * set default shards=3 * Update settings_object.py --------- Co-authored-by: Joshua Kim <joshua@marqo.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Have unit tests been run against this PR? (Has there also been any additional testing?)
Related Python client changes (link commit/PR here)
Related documentation changes (link commit/PR here)
Other information:
Please check if the PR fulfills these requirements