-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Parallel (Processes) in Marqo #523
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farshidz
requested changes
Jun 30, 2023
farshidz
approved these changes
Jun 30, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
remove Parallel processes in marqo
What is the current behavior? (You can also link to an open issue here)
we have a
processes
parameter in marqoadd_or_replace_documents
API that uses multiprocess to index documents.What is the new behavior (if this is a feature change)?
We decide to remove the support of the multiprocess feature and remove the support of this parameter in the API, for the following reasons:
It blows out memory (it seems that loaded models are replicated for each process)
The (time) overhead from starting multiple processes makes it unviable for ~30 second HTTP requests. It only makes sense for much longer running requests (which is an unusual pattern for a REST API)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
yes, this is a breaking change
Have unit tests been run against this PR? (Has there also been any additional testing?)
passes
Related Python client changes (link commit/PR here)
on going
Related documentation changes (link commit/PR here)
parameter processes has already been removed from the doc
Other information:
not
Please check if the PR fulfills these requirements