POC: using a single kNN opensearch field #509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandu-k
commented
Jun 16, 2023
| return f"{searchable_attribs_filter}{contextualised_user_filter}" | ||
|
|
||
|
|
||
| def build_searchable_attributes_filter(vector_properties_to_search: Sequence) -> str: |
There was a problem hiding this comment.
@vicilliar Logic for a creating searchable attributes filter
vicilliar
reviewed
Jun 16, 2023
src/marqo/tensor_search/backend.py
Outdated
| @@ -87,21 +87,7 @@ def add_customer_field_properties(config: Config, index_name: str, | |||
| multimodal_customer_field_names = set([(field_name, "_") for field_name in list(multimodal_combination_fields)]) | |||
| knn_field_names = knn_field_names.union(multimodal_customer_field_names) | |||
|
|
|||
| body = { | |||
There was a problem hiding this comment.
this is called once per field?
vicilliar
reviewed
Jun 16, 2023
| # {'Description': {'type': 'text'}, {'Description': {'type': 'text'}, | ||
| # 'Genre': {'type': 'text'}, 'Genre': {'type': 'text'}, | ||
| # 'Title': {'type': 'text'}, 'Title': {'type': 'text'}, | ||
| # 'my_combination_field': {'properties': {'lexical_field': {'type': 'text'}, -----> 'my_combination_field.lexical_field': {'type': 'text'}, |
There was a problem hiding this comment.
what if the field name has a .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Have unit tests been run against this PR? (Has there also been any additional testing?)
Related Python client changes (link commit/PR here)
Related documentation changes (link commit/PR here)
Other information:
Please check if the PR fulfills these requirements