Replicas limit #465
Merged
Replicas limit #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandu-k
reviewed
May 8, 2023
vicilliar
approved these changes
May 8, 2023
| @@ -128,7 +128,7 @@ | |||
| NsFields.hnsw_ef_construction: { | |||
| "type": "integer", | |||
| "minimum": 1, | |||
| "maximum": int(read_env_vars_and_defaults(EnvVars.MARQO_EF_CONSTRUCTION_MAX_VALUE)), | |||
| "maximum": read_env_vars_and_defaults_ints(EnvVars.MARQO_EF_CONSTRUCTION_MAX_VALUE), | |||
There was a problem hiding this comment.
may be the wrong PR to comment this on, but maybe we should rename MARQO_EF_CONSTRUCTION_MAX_VALUE to MARQO_MAX_EF_CONSTRUCTION_VALUE, because if you observe the other env vars, the word MAX always comes first. It may confuse users if we keep EF like that.
There was a problem hiding this comment.
good thinking, to keep things consistent, but that would technically be a breaking change
vicilliar
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
we add a new environmental variable, "MARQO_MAX_NUMBER_OF_REPLICAS" to control the maximum number of replicas that can be set when creating an index.
What is the current behavior? (You can also link to an open issue here)
no limit for number of replicas
What is the new behavior (if this is a feature change)?
we have this limit now
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Have unit tests been run against this PR? (Has there also been any additional testing?)
running
Related Python client changes (link commit/PR here)
no
Related documentation changes (link commit/PR here)
will do
Other information:
no
Please check if the PR fulfills these requirements