Add HNSW hyperparameters m, ef_construction to default index_settings config
#386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test run: https://github.com/marqo-ai/marqo/actions/runs/4380687872/jobs/7668033896
|
|
Will require PR to marqodocs to add these changes to |
vicilliar
reviewed
Mar 29, 2023
| @@ -56,6 +56,16 @@ class IndexSettingsField: | |||
| number_of_shards = "number_of_shards" | |||
| number_of_replicas = "number_of_replicas" | |||
|
|
|||
| ann_parameters = "ann_parameters" | |||
| ann_method = "method" | |||
| ann_metric = "space_type" | |||
There was a problem hiding this comment.
why isn't this just ann_space_type
| @@ -94,21 +95,13 @@ def add_customer_field_properties(config: Config, index_name: str, | |||
| utils.generate_vector_name(field_name[0])): { | |||
| "type": "knn_vector", | |||
| "dimension": model_properties["dimensions"], | |||
| "method": { | |||
There was a problem hiding this comment.
this could be "ann_method" for clarity, since it's handling ann parameters. but may not be important as this isn't exposed to users
There was a problem hiding this comment.
IIRC, this is explicitly defined by Opensearch, we must follow their convention.
|
rerunning unit tests: https://github.com/marqo-ai/marqo/actions/runs/4551020731 |
|
Rerunning unit tests: https://github.com/marqo-ai/marqo/actions/runs/4568709045 |
* Updated readme with new examples from the documentation and reordered the examples to keep document deletion and index deletion at the bottom * removed accidental duplication of example * updated links in README examples to more stable versions
vicilliar
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
(#206)
Have unit tests been run against this PR? (Has there also been any additional testing?)
Related Python client changes (link commit/PR here)
Index.create(, I don't think these are important enough to increase the complexity of the interface.Related documentation changes (link commit/PR here)
Please check if the PR fulfills these requirements