Add SigLIP imagePreprocessor config #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanliAlex
requested changes
Dec 11, 2024
src/marqo_commons/model_registry/model_properties_data/open_clip_properties.py
Outdated
Show resolved
Hide resolved
f800250 to
c0d5278
Compare
SigLIP models do not use the default OpenCLIP preprocessor which can result in failure to load an index properly. Also set size as per the base model's image_size configuration. See https://docs.marqo.ai/latest/models/marqo/bring-your-own-model/#example-2-load-a-custom-openclip-model-from-a-public-url-with-custom-configurations > It is very important to provide the correct imagePreprocessor > configuration to match the model architecture as Marqo can not infer > the correct configuration from the model name when you load a > checkpoint file and will use the default configuration("OpenCLIP")
c0d5278 to
43f1cc4
Compare
wanliAlex
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SigLIP models do not use the default OpenCLIP preprocessor which can result in failure to load an index properly.
Also set size as per the base model's image_size configuration.
See https://docs.marqo.ai/latest/models/marqo/bring-your-own-model/#example-2-load-a-custom-openclip-model-from-a-public-url-with-custom-configurations