Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API test for multi query #9

Merged
merged 2 commits into from
Feb 20, 2023
Merged

API test for multi query #9

merged 2 commits into from
Feb 20, 2023

Conversation

pandu-k
Copy link
Collaborator

@pandu-k pandu-k commented Feb 7, 2023

Tests for multi query search.

@pandu-k
Copy link
Collaborator Author

pandu-k commented Feb 7, 2023

To be merged, after marqo-ai/marqo#307 is merged.

@pandu-k pandu-k mentioned this pull request Feb 7, 2023
Merged
3 tasks
vicilliar
vicilliar approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@vicilliar vicilliar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! if you want, you can try adding lexical tests to ensure it fails, but that's in unit tests already.

@pandu-k pandu-k merged commit 5dbcabc into mainline Feb 20, 2023
@pandu-k pandu-k deleted the multi_query_test branch February 20, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicilliar vicilliar vicilliar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pandu-k @vicilliar