Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New enhancements (Secondary cleaning switch and Mopping/sweeping route) #9

Closed
kodifan opened this issue May 13, 2021 · 7 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@kodifan
Copy link

kodifan commented May 13, 2021

Halo
any chance for adding two more enhancements for this integration?

  • Secondary cleaning switch
  • Mopping/sweeping route (0=S or Y=1)
    I see those are available in both specifications_viomi_v13_1.yaml and specifications_viomi_v19_1.yaml files.

One more thing: is is possible to read light (vacuum led status) ? You can turn it off or on, but i cant see such property either in your integration or specification file.

@marotoweb
Copy link
Owner

The two states can be easily implemented, in fact there are more values ​​that could be obtained without significantly decreasing the performance however the led status does not exist in the specifications

@kodifan
Copy link
Author

kodifan commented May 14, 2021

Would be great;) more is always better;)

marotoweb added a commit that referenced this issue May 16, 2021
@marotoweb
Copy link
Owner

Check out ce38c4d

@marotoweb marotoweb self-assigned this May 16, 2021
@marotoweb marotoweb added the enhancement New feature or request label May 16, 2021
@kodifan
Copy link
Author

kodifan commented May 17, 2021

Im new in all this Home Assistant stuffs. So maybe I don't have knowledge to do this correctly but those attributes seems to be read only ? Is it the way to set them ? I don't see any set_route or set_repeat command in your vacuum.py file

@marotoweb
Copy link
Owner

marotoweb commented May 22, 2021

Hi, I'm Roberto

In fact it is already possible to change any rewritable property values simply using the vacuum.send_command service

Script example:

alias: 'Change  repeat_state (1=on, 0=off)'
sequence:
  - data:
      command: set_properties
      params:
        - siid: 4
          piid: 1
          value: 1
    service: vacuum.send_command
    target:
      entity_id: vacuum.viomi_se
mode: single

imagem

imagem

@kodifan
Copy link
Author

kodifan commented May 24, 2021

Hi Roberto, yes i noticed sorry for my mistake (Krzysztof is a person that you have forked your repository from).
Thanks for the tip i will try it for sure.
So basically i can set other attributes this way too ? Is it enough for most properties to add them to ALL_PROPS and mapping section (with correct siid and piid of course) in vacuum.py file ?

@marotoweb
Copy link
Owner

Basically yes, you can confirm in the specifications file which properties can be changed and their values

@kodifan kodifan closed this as completed May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants