Improve performance when validating the same timezones many times #135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
Firstly thanks for this project, it's much needed.
When upgrading to the latest version we found a reduction in performance where we were using
utcToZonedTime()
on many dates.It looks like the improvement to use
Intl.DateTimeFormat
(in #129) for validating timezone strings came with a performance cost.This PR looks to cache valid IANA timezones to improve performance when validating the same timezone many times.
For example, calling
tzParseTimezone
100 times with the sameAmerica/New_York
timezone, this PR takes it down from ~17-19ms back down to 3-4ms.The other file changes look just from the linting being run on the file.
Thanks!