Fix <Admin requireAuth> forbids access to custom routes with no layout

[fzaninotto]

Problem

<Admin requireAuth> is used to forbid anonymous anonymous users to see the UI while the auth status is being checked.

But anonymous users should be able to see the custom routes with no layout, e.g. to let them access a registration page, or a "forgot my password" page.

This currently doesn't work. CoreAdminRoutes does display custom routes with no layout when accessed by an anonymous user, but it redirects anonymous users to login immediately.

Root Cause

CoreAdminRoutes calls checkAuth with logoutOnFailure set to true, so anonymous users will be logged out even when accessing a custom route with no layout.

react-admin/packages/ra-core/src/core/CoreAdminRoutes.tsx

Lines 41 to 49 in 6b78433

	useEffect(() => {
	if (requireAuth) {
	checkAuth()
	.then(() => {
	setCanRender(true);
	})
	.catch(() => {});
	}
	}, [checkAuth, requireAuth]);

Solution

• Do not log users out on auth check failure when requireAuth is true
• Log users out only when they try to access non-custom routes