Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix <AutocompleteInput createLabel> #9712

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

fzaninotto
Copy link
Member

Closes #9616

@erwanMarmelab erwanMarmelab added this to the 4.16.13 milestone Mar 13, 2024
@erwanMarmelab erwanMarmelab merged commit dbeea1d into master Mar 13, 2024
11 checks passed
@erwanMarmelab erwanMarmelab deleted the fix-autocompleteinput-createlabel branch March 13, 2024 10:49
@davidhenley
Copy link
Contributor

davidhenley commented Mar 21, 2024

Just so you guys know, after updating, the create is now passing the entire "Create xxx" to the useCreateSuggestionContext filter. So if I type "Test" it will pass "Create Test" to the filter when before this it would just pass "Test"

createLabel="Create New Label"
createItemLabel="Create %{item}"

CleanShot 2024-03-21 at 08 11 06

CleanShot 2024-03-21 at 08 11 10

CleanShot 2024-03-21 at 08 11 44

CleanShot 2024-03-21 at 08 11 48

@erwanMarmelab
Copy link
Contributor

erwanMarmelab commented Mar 22, 2024

useCreateSuggestionContext

Thanks for the report @davidhenley, do not hesitate to create an issue with a CodeSandbox 👍

@davidhenley
Copy link
Contributor

davidhenley commented Mar 22, 2024

@erwanMarmelab Sorry I wish I had the time. I ended up just having to revert back to the last version to fix it. I'll create a enterprise support request when I can.

djhi added a commit that referenced this pull request Jun 24, 2024
mjarosch pushed a commit to mjarosch/react-admin that referenced this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutocompleteInput createLabel prop does not work.
3 participants