Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TranslatableInputs should support fullWitdh and sx props #9104

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Jul 17, 2023

No description provided.

@djhi djhi added the RFR Ready For Review label Jul 17, 2023
@djhi djhi changed the base branch from master to next July 17, 2023 14:40
@djhi djhi changed the title Translatable inputs sx fullwidth Add support for fullWitdh and sx prop to TranslatableInputs Jul 17, 2023
@djhi djhi force-pushed the translatable-inputs-sx-fullwidth branch from bccd3c8 to 51b2eaa Compare July 17, 2023 14:49
@djhi djhi changed the base branch from next to master July 17, 2023 14:49
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a 'Stacked' story, demonstrating how one can use the sx prop to change the layout of the inputs, since this is probably one of the most common use for it?

@djhi
Copy link
Collaborator Author

djhi commented Jul 19, 2023

Can you add a 'Stacked' story, demonstrating how one can use the sx prop to change the layout of the inputs, since this is probably one of the most common use for it?

So, the sx prop is actually not enough to allow creating a vertical stack due to the way tabs works. Unfortunately, we'll have to wait for the next minor release and wrap the tab content children in a Stack

@slax57
Copy link
Contributor

slax57 commented Jul 19, 2023

Okay so let's merge this already, as this fix is still relevant

@slax57 slax57 added this to the 4.12.2 milestone Jul 19, 2023
@slax57 slax57 merged commit b59f529 into master Jul 19, 2023
@slax57 slax57 deleted the translatable-inputs-sx-fullwidth branch July 19, 2023 08:14
@slax57 slax57 changed the title Add support for fullWitdh and sx prop to TranslatableInputs Fix TranslatableInputs should support fullWitdh and sx props Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants