Fix <WithRecord>
render
prop type
#8993
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#8963 introduced a change to
<WithRecord>
, which allowed therender
prop return aReactNode
instead of aReactElement
.But since
<WithRecord>
currently returns the result of therender
function without wrapping it in JSX first, we get the following TS error:Solution
Wrap the result of the
render
function in a React Fragment.Also, I removed the the
RenderRecordFunction
type because to meFunctionField
andWithRecord
do not share the samerender
function signature.