Fix <DateField> props types
#8844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slax57
requested changes
Apr 20, 2023
|
@slax57 Done ✅. I made the changes through GitHub’s UI vs a full editor (hoping this is a small/simple edit 😄). Please let me know if I need to download locally to verify anything 👍🏻 (in case CI has some blindspots). |
slax57
approved these changes
Apr 21, 2023
DateField props TS types<DateField> props types
<DateField> props types<DateField> props types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies the types for
DateField. Bothlocalesandoptionsare expected to be used in.toLocaleDateString, which has more specific (and built-in/native) types we can leverage. Setting to more explicit types provides useful auto-correct and documentation.