Fix <RichTextField>
XSS vulnerability
#8644
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
<RichTextField>
leverages thedangerouslySetInnerHTML
attribute, expecting the value to be already sanitized server-side.If it is not, a malicious user can execute an XSS attack by injecting malicious data.
Proof-of-concept:
Solution
Sanitize the value by default using DomPurify. This adds 8.6kB gzipped to the final bundle for people using
<RichTextField>
, but it's inevitable.