Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show focus on clear buttons in ResettableTextfield #8447

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Show focus on clear buttons in ResettableTextfield #8447

merged 1 commit into from
Nov 30, 2022

Conversation

antoinefricker
Copy link
Contributor

Ripple effects had been disabled on resettable textfields, this removes the feedback during tabulation navigation.

@WiXSL
Copy link
Contributor

WiXSL commented Nov 30, 2022

I wonder why it was disabled in the first place

Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @WiXSL
@djhi or @fzaninotto do you have any clues?

@djhi
Copy link
Collaborator

djhi commented Nov 30, 2022

I wonder why it was disabled in the first place

For the same reason we used to disable button ripples by default before: performances

@djhi djhi added this to the 4.6 milestone Nov 30, 2022
@djhi djhi merged commit fd4cf3c into master Nov 30, 2022
@djhi djhi deleted the zd955 branch November 30, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants