Fix <FormDataConsumer> usage with Field children
#8445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slax57
approved these changes
Nov 29, 2022
FormDataConsumer warning <SimpleFormIterator> example on how to work with Fields, and remove confusing warning in <FormDataConsumer>
djhi
approved these changes
Nov 29, 2022
djhi
reviewed
Nov 29, 2022
| <Labeled label="Url"> | ||
| <TextField source={getSource('url')} /> | ||
| <TextField source="url" record={scopedFormData} /> |
There was a problem hiding this comment.
Are you sure about the removal of getSource ?
There was a problem hiding this comment.
Yes, this solution was tested in the context of this PR: #8359 (have a look at the comments)
There was a problem hiding this comment.
Does it mean we don't need getSource anymore?
<SimpleFormIterator> example on how to work with Fields, and remove confusing warning in <FormDataConsumer><FormDataConsumer> usage Field children
<FormDataConsumer> usage Field children<FormDataConsumer> usage with Field children
fzaninotto
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8427