Add ability to reorder fields in DatagridConfigurable and SimpleFormConfigurable #8416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
commented
Nov 21, 2022
| @@ -177,7 +182,7 @@ const StyledPaper = styled(Paper, { | |||
| overridesResolver: (props, styles) => styles.root, | |||
| })(({ theme }) => ({ | |||
| position: 'fixed', | |||
| zIndex: theme.zIndex.modal, | |||
| zIndex: theme.zIndex.modal + 1, | |||
There was a problem hiding this comment.
This one is a fix for a regression appearing since #8395: the configure button appears on top of the inspector
WiXSL
approved these changes
Nov 22, 2022
WiXSL
suggested changes
Nov 22, 2022
|
Screencasts added. As for the tests, they are left as an exercise for the reader ;) |
fzaninotto
commented
Nov 22, 2022
Comment on lines
45
to
80
| const handleMove = (index1, index2) => { | ||
| const index1Pos = availableFields.findIndex( | ||
| // eslint-disable-next-line eqeqeq | ||
| field => field.index == index1 | ||
| ); | ||
| const index2Pos = availableFields.findIndex( | ||
| // eslint-disable-next-line eqeqeq | ||
| field => field.index == index2 | ||
| ); | ||
| if (index1Pos === -1 || index2Pos === -1) { | ||
| return; | ||
| } | ||
| let newAvailableFields; | ||
| if (index1Pos > index2Pos) { | ||
| newAvailableFields = [ | ||
| ...availableFields.slice(0, index2Pos), | ||
| availableFields[index1Pos], | ||
| ...availableFields.slice(index2Pos, index1Pos), | ||
| ...availableFields.slice(index1Pos + 1), | ||
| ]; | ||
| } else { | ||
| newAvailableFields = [ | ||
| ...availableFields.slice(0, index1Pos), | ||
| ...availableFields.slice(index1Pos + 1, index2Pos + 1), | ||
| availableFields[index1Pos], | ||
| ...availableFields.slice(index2Pos + 1), | ||
| ]; | ||
| } | ||
| setAvailableFields(newAvailableFields); | ||
| setFields(fields => | ||
| newAvailableFields | ||
| .filter(field => !omit?.includes(field.source)) | ||
| .filter(field => fields.includes(field.index)) | ||
| .map(field => field.index) | ||
| ); | ||
| }; |
There was a problem hiding this comment.
Fun fact: this method was almost entirely written by gitHub Copilot!
WiXSL
approved these changes
Nov 22, 2022
slax57
requested changes
Nov 23, 2022
packages/ra-ui-materialui/src/list/datagrid/SelectColumnsButton.tsx
Outdated
Show resolved
Hide resolved
slax57
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enregistrement.de.l.ecran.2022-11-21.a.18.28.25.mov
Enregistrement.de.l.ecran.2022-11-21.a.18.31.40.mov