Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeScript] Fix DeleteParams id type doesn't use generic type #8208

Merged
merged 1 commit into from
Sep 29, 2022
Merged

[TypeScript] Fix DeleteParams id type doesn't use generic type #8208

merged 1 commit into from
Sep 29, 2022

Conversation

zhujinxuan
Copy link
Contributor

@zhujinxuan zhujinxuan commented Sep 28, 2022 •
edited
Loading

Update a type definition to make DeleteParams is consistent with the definition in GetOne and GetMany.

The benefit is the programmer don't need to distinguish number or string once the RecordType is given

react-admin/packages/ra-core/src/types.ts

Line 147 in 99106d6

id: RecordType['id'];

@fzaninotto fzaninotto merged commit c03fdf2 into marmelab:master Sep 29, 2022
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 4.4.0 milestone Sep 29, 2022
@fzaninotto fzaninotto changed the title Update DeleteParams id type [TypeScript] Fix DeleteParams id type doesn't use generic type Sep 29, 2022
@zhujinxuan zhujinxuan mentioned this pull request Mar 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@zhujinxuan @fzaninotto