Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ReferenceInput fetching error makes AutocompleteInput unusable #8183

Merged
merged 10 commits into from
Sep 22, 2022
Merged

Fix ReferenceInput fetching error makes AutocompleteInput unusable #8183

merged 10 commits into from
Sep 22, 2022

Conversation

fzaninotto
Copy link
Member

No description provided.

@fzaninotto fzaninotto added the RFR Ready For Review label Sep 21, 2022
WiXSL
WiXSL suggested changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@WiXSL WiXSL left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the SelectArrayInput and CheckboxGroupInput and DatagridInput have the same treatment as AutocompleteInput and SelectInput ?

WiXSL
WiXSL suggested changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@WiXSL WiXSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint in ReferenceArrayInput.spec.tsx

@fzaninotto @slax57
Update packages/ra-ui-materialui/src/input/ReferenceArrayInput.storie…
65c9128 
…s.tsx

Co-authored-by: Jean-Baptiste Kaiser <jb@marmelab.com>
@WiXSL WiXSL merged commit 9c99fed into master Sep 22, 2022
@WiXSL WiXSL deleted the fir-referenceinput-fetch-error branch September 22, 2022 12:56
@WiXSL WiXSL added this to the 4.3.4 milestone Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WiXSL WiXSL WiXSL approved these changes

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@fzaninotto @WiXSL @slax57